RFR: JEP 367: Remove the Pack200 Tools and API

[David Holmes]

On 21/11/2019 11:01 am, Mandy Chung wrote:
> (bcc jdk-dev.   The review can continue on core-libs-dev)
> 
> Hi Vicente,
> 
> The following files should also be removed.
>     make/launcher/Launcher-jdk.pack.gmk

There are a number of build changes to be made:

./make/autoconf/compare.sh.in:export UNPACK200="@FIXPATH@ 
@BOOT_JDK@/bin/unpack200"
./make/autoconf/flags-cflags.m4:    # unpack200.exe.
./make/launcher/Launcher-jdk.pack.gmk
./make/scripts/compare_exceptions.sh.incl:      ./bin/unpack200

which need to be reviewed on build-dev

> test/jdk/java/util/jar/Pack200/*
> 
> The following files reference pack200 in its comment.  I'm not sure if 
> they need update or not.
> 
> src/java.base/solaris/native/libjvm_db/libjvm_db.c
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CompressedReadStream.java 
> 
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CompressedStream.java 

Same comments in ./src/hotspot/share/code/compressedStream.hpp

Cheers,
David

> Is a CSR ready to be reviewed?
> 
> Mandy
> 
> 
> On 11/20/19 4:11 PM, Vicente Romero wrote:
>> moving the discussion to core-libs. I have updated the webrev [1], 
>> after removing the reference found by David and another one I found 
>> with a help text at:
>>
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties
>>
>> Thanks,
>> Vicente
>>
>> [1] http://cr.openjdk.java.net/~vromero/8234542/webrev.01/
>>
>> On 11/20/19 6:26 PM, David Holmes wrote:
>>> Hi Vicente,
>>>
>>> On 21/11/2019 9:22 am, Vicente Romero wrote:
>>>> Hi David,
>>>>
>>>> This is the list that appears in the `Discussion` tag in the JEP [1]. 
>>>
>>> Sure but we're not discussing the JEP, this is now the RFR.
>>>
>>> Cheers,
>>> David
>>>
>>>> I will remove that reference,
>>>>
>>>> Thanks,
>>>> Vicente
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8232022
>>>>
>>>> On 11/20/19 6:10 PM, David Holmes wrote:
>>>>> Hi Vicente,
>>>>>
>>>>> Not sure the best mailing list for this review ... jdk-dev may not 
>>>>> be well monitored.
>>>>>
>>>>> Is there a separate review thread for the actual tool removal 
>>>>> (jdk.pack) and build system changes?
>>>>>
>>>>> This removal seems okay, but I found one additional reference:
>>>>>
>>>>> ./src/utils/IdealGraphVisualizer/nbproject/project.properties:auxiliary.org-netbeans-modules-apisupport-installer.pack200-enabled=false 
>>>>>
>>>>>
>>>>> Thanks,
>>>>> David
>>>>> -----
>>>>>
>>>>> On 21/11/2019 8:54 am, Vicente Romero wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I need a reviewer for the changes to remove pack200 and unpack200 
>>>>>> from the JDK. The webrev with the removal is at [1]. This patch is 
>>>>>> the "implementation" of JEP 367 [2]. The patch is basically 
>>>>>> removing the Pack200 related APIs plus its implementation plus any 
>>>>>> reference to it in other tools like `jar`. In the case of `jar`, 
>>>>>> Pack200 was only used if the `-n` flag was passed to the tool. I 
>>>>>> have removed the code that was executed when that flag was passed. 
>>>>>> I have also removed all the tests for Pack200.
>>>>>>
>>>>>> Thanks,
>>>>>> Vicente
>>>>>>
>>>>>> [1] http://cr.openjdk.java.net/~vromero/8234542/webrev.00/
>>>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8232022
>>>>
>>
>