RFR: 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem

[Langer, Christoph]

Hi Lance,

thanks again. Makes sense to keep comments consistent. So this is what I’m going to push tomorrow: http://cr.openjdk.java.net/~clanger/webrevs/8234089.5/

Cheers
Christoph

From: Lance Andersen <lance.andersen at oracle.com>
Sent: Mittwoch, 20. November 2019 19:02
Cc: Langer, Christoph <christoph.langer at sap.com>; nio-dev <nio-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem

Hi Christoph,

Again, thank you for your efforts here.

Overall I think your latest changes look fine.  I would like to suggest that for the methods that you added for MR support, that we make sure the 1st character in the comment is capitalized prior to your push of the changes.  I know this was not that way prior, but I think it helps with consistency.

BTW,  I am not sure that JarFileSystemProvider was actually ever used(JarFileSystem was though) as when I look at the installed providers on my Mac, I see:

[sun.nio.fs.MacOSXFileSystemProvider at 5b2133b1, jdk.nio.zipfs.ZipFileSystemProvider at 72ea2f77<mailto:jdk.nio.zipfs.ZipFileSystemProvider at 72ea2f77>, jdk.internal.jrtfs.JrtFileSystemProvider at 33c7353a<mailto:jdk.internal.jrtfs.JrtFileSystemProvider at 33c7353a>]


Best
Lance
On Nov 20, 2019, at 10:02 AM, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:



On 20/11/2019 13:39, Langer, Christoph wrote:
Hi Alan,

makes sense. I’ve updated the patch: http://cr.openjdk.java.net/~clanger/webrevs/8234089.4/

The updated test looks okay.

-Alan

[cid:image001.gif at 01D5A0C8.666731C0]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>