RFR: 8234964: failure_handler: gather more environment information on Windows, Solaris and Linux

[Vyom Tiwari]

Hi Julia,

Changes looks OK to me although i have one question, in case of Solaris you
use explicit path to ifconfig(ifconfig.app=/sbin/ifconfig).

Does Solaris by default doesn't set the /sbin folder to user's 'PATH'
environment variable ?.

Thanks,
Vyom

On Fri, Nov 29, 2019 at 12:18 AM Igor Ignatyev <igor.ignatyev at oracle.com>
wrote:

> Hi Julia,
>
> looks good to me.
>
> to make it more consistent w/ other tools, I'd move all ifconfig (incl.
> one on macOS) to 'net' category, i.e. rename them to net.ifconfig, this
> will require also moving all netstat.* on macOS and solaris to 'net' as
> well. I don't insist on it, though.
>
> -- Igor
>
> > On Nov 28, 2019, at 10:15 AM, Julia Boes <julia.boes at oracle.com> wrote:
> >
> > Hi,
> >
> > In the case of test failure, the environment information of 'ifconfig
> -a' is already gathered on macOS systems.
> >
> > The following enhancement allows the same information to be gathered on
> Linux, Solaris and Windows systems (in the latter case 'ipconfig /all').
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8234964
> >
> > Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234964/webrev.00/
> >
> > Regards,
> >
> > Julia
> >
>
>

-- 
Thanks,
Vyom