RFR (XS): 8231161: Wrong return type in code sample in Collector API documentation
Julia Boes
julia.boes at oracle.com
Thu Oct 3 18:05:59 UTC 2019
Hi Stuart,
Thanks for the review. I made the changes you mentioned.
Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.01/
If you would like to sponsor for this change, that would be great!
Regards,
Julia
On 03/10/2019 18:44, Stuart Marks wrote:
>
>
> On 10/2/19 2:36 AM, Julia Boes wrote:
>> This is a minor fix of the Collector class-level documentation, where
>> the wrong type declaration was used in a code sample.
>>
>> While at it, I added a compilation test for all code samples of this
>> class-level javadoc.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8231161
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jboes/webrevs/8231161/webrev.00/index.html
>
> Hi Julia,
>
> Thanks for this small fix and for writing the test.
>
> A couple very tiny comments on the test:
> - sort the import lines
> - remove extra blank lines at end
>
> Otherwise it looks great.
>
> Did you need a sponsor for this change?
>
> s'marks
More information about the core-libs-dev
mailing list