RFR: JDK-8231882: --add-modules ALL-MODULE-PATH is not handled properly

Alexander Matveev alexander.matveev at oracle.com
Fri Oct 4 21:20:29 UTC 2019


Looks good.

On 10/4/2019 12:14 PM, Alexey Semenyuk wrote:
> Yes, it is. Sorry, my bad, I didn't notice it. Looks good then!
>
> - Alexey
>
> On 10/4/2019 3:11 PM, Andy Herrick wrote:
>> isn't what this change in BasicTest in this webrev does ?
>>
>> It passes on all platforms with Mach 5 builds.
>>
>> /Andy
>>
>> On 10/4/2019 3:05 PM, Alexey Semenyuk wrote:
>>> Please enable `ALL-MODULE-PATH` parameter of 
>>> BasicTest.testAddModules() test. It should pass with this fix.
>>>
>>> - Alexey
>>>
>>> On 10/4/2019 2:15 PM, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> This change eliminates the ModuleManager class and uses 
>>>> ModuleFinder class to locate modules.
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8231882
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8231882/
>>>>
>>>> /Andy
>>>>
>>>
>



More information about the core-libs-dev mailing list