JDK 14 RFR of JDK-8231202: Suppress warnings on non-serializable non-transient instance fields in serializable classes

Joe Darcy joe.darcy at oracle.com
Wed Oct 9 17:10:36 UTC 2019


Thanks for the reviews.

Running some final checks, I'd also like to include two more 
@SuppressWarnings to clear the issues in java.base outside of 
java.util.concurrent; patch below.

Thanks,

-Joe

diff -r 6e017b301287 
src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java
--- 
a/src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java 
Wed Oct 09 09:57:41 2019 -0700
+++ 
b/src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java 
Wed Oct 09 10:07:53 2019 -0700
@@ -49,6 +49,7 @@
      private static final long serialVersionUID = 100L;
      private static final PlatformLogger logger = 
HttpURLConnection.getHttpLogger();

+    @SuppressWarnings("serial") // Not statically typed as Serializable
      private final HttpCallerInfo hci;

      // These maps are used to manage the GSS availability for diffrent
@@ -67,6 +68,7 @@
      }

      // The HTTP Negotiate Helper
+    @SuppressWarnings("serial") // Not statically typed as Serializable
      private Negotiator negotiator = null;

     /**

On 10/9/2019 7:28 AM, Roger Riggs wrote:
> +1
>
> On 10/9/19 7:56 AM, Chris Hegarty wrote:
>> Joe,
>>
>> On 05/10/2019 04:04, Joe Darcy wrote:
>>> Hello,
>>>
>>> Please review the revised fix:
>>>
>>> http://cr.openjdk.java.net/~darcy/8231202.1/
>>
>> Given the prior discussion in this thread, then I think this version 
>> looks fine ( which consists solely of warning suppressions ).
>>
>> -Chris.
>


More information about the core-libs-dev mailing list