RFR: JDK-8232042: [macos] Installation fails if application name contains spaces

Alexey Semenyuk alexey.semenyuk at oracle.com
Thu Oct 10 18:42:54 UTC 2019


Looks good.

It would be good to have this fix accompanied with the relevant jtreg test.

- Alexey

On 10/9/2019 11:50 PM, Alexander Matveev wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> - Patch is based on JDK-8231856 fix.
> - Fixed by using URI to escape URLs. URLEncoder.encode() encodes form 
> data and it will use "+" for space. pkg build tool expects URL with 
> space encoded as "%20".
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8232042
>
> [2] http://cr.openjdk.java.net/~almatvee/8232042/webrev.01/
>
> Thanks,
> Alexander



More information about the core-libs-dev mailing list