RFR 8231427 (test) Warning cleanup in tests of java.io.Serializable

Lance Andersen lance.andersen at oracle.com
Fri Oct 11 16:43:07 UTC 2019


Updates look good to me :-)

> On Oct 11, 2019, at 11:12 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> Hi Joe,
> 
> Updated with comments added for the reasons of the @SuppressWarnings("serial").
> 
> http://cr.openjdk.java.net/~rriggs/webrev-ser-test-cleanup-8231427-3/
> 
> Thanks, Roger
> 
> 
> On 9/27/19 2:45 PM, Joe Darcy wrote:
>> Hi Roger,
>> 
>> Generally looks fine. Adding some comments about why the @SuppressWarnings annotations were being applied might help future readers of the code.
>> 
>> Cheers,
>> 
>> -Joe
>> 
>> On 9/27/2019 10:02 AM, Roger Riggs wrote:
>>> Please review cleanup of tests in java/io/Serializable. There are warnings for mis-use of
>>> serialization methods and fields; some are intentional as they are the focus of the tests.
>>> The test code had quite a few warnings about raw types, deprecated methods, and
>>> missing serialVersionUIDs, and deprecated methods, etc.
>>> 
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8231427
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs/webrev-ser-test-cleanup-8231427-2/
>>> 
>>> Thanks, Roger
>>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list