RFR: JDK-8231604: Expand junit test added with JDK-8230920

Alexey Semenyuk alexey.semenyuk at oracle.com
Tue Oct 15 13:26:51 UTC 2019


Looks good.

- Alexey

On 10/15/2019 9:17 AM, Andy Herrick wrote:
> revised webrev.02: [3] to accommodate this feedback.
>
> [3] http://cr.openjdk.java.net/~herrick/8231604/webrev.02/
>
> /Andy
>
>
> On 10/15/2019 8:50 AM, Andy Herrick wrote:
>> yes - although the list is ordered (in the order they are added) 
>> there is nothing requiring this, we could change that in future, so I 
>> will modify as you say to assert there are two elements and that 
>> contain the two given names..
>>
>> /Andy
>>
>> On 10/15/2019 8:44 AM, Alexey Semenyuk wrote:
>>> Andy,
>>>
>>> The test seems to assume particular order of launcher names. Is this 
>>> what we have in jpackage?
>>> I'd rather check the result of AppImageFile.getAddLauncherNames() 
>>> call in the test is a list of two elements and names of launchers 
>>> are contained in the list.
>>>
>>> - Alexey
>>>
>>> On 10/15/2019 7:58 AM, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> Simple junit test addition to cover add-launchers in AppInfoFile.
>>>>
>>>> /Andy
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8231604
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8231604/webrev.01/
>>>>
>>>



More information about the core-libs-dev mailing list