RRF: JDK-8232280: close() is not called on return value of Files.walk()

Alexey Semenyuk alexey.semenyuk at oracle.com
Wed Oct 16 22:19:07 UTC 2019


Looks good.

- Alexey

On 10/16/2019 6:04 PM, Andy Herrick wrote:
> The webrev is modified in place to remove one file, and now passes 
> build on all platforms.
>
> /Andy
>
> On 10/16/2019 4:31 PM, Andy Herrick wrote:
>> fixing subject line ...
>>
>> On 10/16/2019 4:03 PM, Andy Herrick wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>> repository (jpackage).
>>>
>>> Fix is to wrap all Files.walk() calls in try-with-resource blocks.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8232280
>>>
>>> [2] http://cr.openjdk.java.net/~herrick/8232280/webrev.01/
>>>
>>> /Andy
>>>



More information about the core-libs-dev mailing list