Jpackage - Limitation with WiX script

[Andy Herrick]

Yes - we should fix.

filed issue: https://bugs.openjdk.java.net/browse/JDK-8232723

/Andy

On 10/20/2019 9:49 AM, Nicolas Roduit wrote:
> Hi,
>
> Previously the WiX script could be overloaded in the resource 
> directory but not anymore. Is there a reason?
>
> It seems important to me to be able to modify the script for 
> real-world applications. For example, my needs are:
> - To build 32-bit package (changing 
> InstallScope="$(var.JpInstallScope)" Platform="x64"/>)
> - Package compression
> - Add an icon to the package
> - Register a custom URI scheme to launch the application in a web context
> - Adding a policy to chrome
> ...
>
> Here is a patch proposal:
>
>
> --- 
> a/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java 
> Sat Oct 19 09:50:19 2019 +0200
> +++ 
> b/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java 
> Sun Oct 20 12:10:26 2019 +0200
> @@ -425,10 +425,8 @@
>              }
>          }
>
> -        try (InputStream is = 
> OverridableResource.readDefault("main.wxs")) {
> -            Files.copy(is, Paths.get(
> - getConfig_ProjectFile(params).getAbsolutePath()));
> -        }
> +        Path wixScript = 
> Paths.get(getConfig_ProjectFile(params).getAbsolutePath());
> +        createResource("main.wxs", params).saveToFile(wixScript);
>
>          return data;
>      }
>
>
> Kind Regards,
>
> Nicolas
>