Review Request JDK-8232617: Update the outdated code comments in java.lang.System class

[Mandy Chung]

On 10/20/19 3:50 PM, David Holmes wrote:
> On 19/10/2019 10:38 am, Mandy Chung wrote:
>> thanks. I think "separated from" reads right to me.  I will leave it 
>> as is.
>
> I think "separately" or "separate" seems more correct here. And if 
> we're picking on grammar then it should be "The VM ..." and "of this 
> class" rather than "for this class".
>
Thanks.   Updated:

     /* Register the natives via the static initializer.
      *
      * The VM will invoke the initPhase1 method to complete the initialization
      * of this class separate from <clinit>.
      */


Mandy


> Cheers,
> David
>
>> Mandy
>>
>> On 10/18/19 2:46 PM, Brent Christian wrote:
>>> Looks fine.  You might consider s/separated/separately/ .
>>>
>>> -Brent
>>>
>>> On 10/18/19 1:56 PM, Mandy Chung wrote:
>>>> A trivial doc fix:
>>>>
>>>>
>>>> diff --git a/src/java.base/share/classes/java/lang/System.java 
>>>> b/src/java.base/share/classes/java/lang/System.java
>>>> --- a/src/java.base/share/classes/java/lang/System.java
>>>> +++ b/src/java.base/share/classes/java/lang/System.java
>>>> @@ -94,10 +94,8 @@
>>>>   public final class System {
>>>>       /* Register the natives via the static initializer.
>>>>        *
>>>> -     * VM will invoke the initializeSystemClass method to complete
>>>> -     * the initialization for this class separated from clinit.
>>>> -     * Note that to use properties set by the VM, see the constraints
>>>> -     * described in the initializeSystemClass method.
>>>> +     * VM will invoke the initPhase1 method to complete the 
>>>> initialization
>>>> +     * for this class separated from <clinit>.
>>>>        */
>>>>       private static native void registerNatives();
>>>>       static {
>>>>
>>>>
>>>>
>>>> Thanks
>>>> Mandy
>>>>
>>