Review Request JDK-8232617: Update the outdated code comments in java.lang.System class
David Holmes
david.holmes at oracle.com
Mon Oct 21 22:52:05 UTC 2019
+1
Thanks,
David
On 22/10/2019 6:33 am, Brent Christian wrote:
> Looks great. -B
>
> On 10/21/19 10:10 AM, Mandy Chung wrote:
> >
>> Thanks. Updated:
>>
>> /* Register the natives via the static initializer.
>> *
>> * The VM will invoke the initPhase1 method to complete the
>> initialization
>> * of this class separate from <clinit>.
>> */
>>
>>>>
>>>> On 10/18/19 2:46 PM, Brent Christian wrote:
>>>>> Looks fine. You might consider s/separated/separately/ .
>>>>>
>>>>> -Brent
>>>>>
>>>>> On 10/18/19 1:56 PM, Mandy Chung wrote:
>>>>>> A trivial doc fix:
>>>>>>
>>>>>>
>>>>>> diff --git a/src/java.base/share/classes/java/lang/System.java
>>>>>> b/src/java.base/share/classes/java/lang/System.java
>>>>>> --- a/src/java.base/share/classes/java/lang/System.java
>>>>>> +++ b/src/java.base/share/classes/java/lang/System.java
>>>>>> @@ -94,10 +94,8 @@
>>>>>> public final class System {
>>>>>> /* Register the natives via the static initializer.
>>>>>> *
>>>>>> - * VM will invoke the initializeSystemClass method to complete
>>>>>> - * the initialization for this class separated from clinit.
>>>>>> - * Note that to use properties set by the VM, see the
>>>>>> constraints
>>>>>> - * described in the initializeSystemClass method.
>>>>>> + * VM will invoke the initPhase1 method to complete the
>>>>>> initialization
>>>>>> + * for this class separated from <clinit>.
>>>>>> */
>>>>>> private static native void registerNatives();
>>>>>> static {
>>>>>>
>>>>>>
>>>>>>
>>>>>> Thanks
>>>>>> Mandy
>>>>>>
>>>>
>>
More information about the core-libs-dev
mailing list