RFR: 8232613: Move Object.registerNatives into HotSpot

David Holmes david.holmes at oracle.com
Tue Oct 22 13:08:48 UTC 2019


Hi Claes,

On 22/10/2019 8:38 pm, Claes Redestad wrote:
> Hi David,
> 
> On 2019-10-22 01:08, David Holmes wrote:
>> Hi Claes,
>>
>> My only nit with this is that I don't think register_native and 
>> friends belongs in the SystemDictionary class as it has nothing to do 
>> with the SD. This code seems to be all about Methods so that seems 
>> like the place to put this.
> 
> how about this:
> 
> http://cr.openjdk.java.net/~redestad/8232613/open.01/

Much better thanks :) But now I see how jarring the change to the SD 
code is. I don't think this logic really belongs in 
SystemDictionary::resolve_well_known_classes. This is a form of 
pre-initialization ... is it better suited for 
Threads::initialize_java_lang_classes perhaps?

I won't insist on this further change, but may take another look at this 
later.

Thanks,
David


> /Claes


More information about the core-libs-dev mailing list