RFR: JDK-8232186: Add verification for pkg and dmg tests

Andy Herrick andy.herrick at oracle.com
Wed Oct 23 17:07:08 UTC 2019


looks ok to me

/ANdy

On 10/22/2019 5:29 PM, Alexander Matveev wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> - Removed --mac-app-store-category.
> - Added Hello.java test app to support file association on OS X.
> - Modified Hello.java to write output file to user home location if 
> working directory is not writable.
> - Fixed MacHelper:getInstallationDirectory(). It was returning extra 
> /Applications when --install-dir is specified.
> - Fixed SigningPackageTest to use path returned by withExplodedDmg 
> correctly.
> - Added install/uninstall support for pkg and dmg to manage_packages.sh.
> - Fixed replaceFileName(), otherwise on OS X it was not replacing file 
> name correctly, since file name does not have extension.
> - Added NameWithSpaceTest.
> - Removed OptionsTest which is covered by other tests.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8232186
>
> [2] http://cr.openjdk.java.net/~almatvee/8232186/webrev.02/
>
> Thanks,
> Alexander


More information about the core-libs-dev mailing list