RFR: JDK-8232723: make the resource file main.wxs over-ridable
Alexey Semenyuk
alexey.semenyuk at oracle.com
Wed Oct 23 17:35:32 UTC 2019
Looks good.
- Alexey
On 10/23/2019 1:29 PM, Andy Herrick wrote:
> revised test (webrev.03 [4]) as per feedback from Alexey.
>
> [4] http://cr.openjdk.java.net/~herrick/8232723/webrev.03
>
> /Andy
>
> On 10/23/2019 9:25 AM, Andy Herrick wrote:
>> revised to add test webrev.02 at [3]
>>
>> [3] http://cr.openjdk.java.net/~herrick/8232723/webrev.02
>>
>> /Andy
>>
>> On 10/22/2019 2:57 PM, Alexey Semenyuk wrote:
>>> Looks good.
>>>
>>> It would be good to have a test for this change as a part of this
>>> fix or as a follow up CR.
>>>
>>> - Alexey
>>>
>>> On 10/22/2019 2:50 PM, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>>>> repository (jpackage).
>>>>
>>>> use createResource() to get an over-ridable resource.
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8232723
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8232723/webrev.01
>>>>
>>>> /Andy
>>>>
>>>
More information about the core-libs-dev
mailing list