RFR: JDK-8233138: Error 2343 when using --win-dir-chooser

[Alexey Semenyuk]

On 10/30/2019 8:12 PM, Alexander Matveev wrote:
> Hi Alexey,
>
> Looks good. 

> Did you test it by trying to install into existing folder? I remember 
> having issues reading some variables in libwixhelper.cpp.
Yes, I did. Without the fix in libwixhelper.cpp it allowed to install in 
non-empty directory.

- Alexey
>
> Thanks,
> Alexander
>
> On 10/30/2019 1:42 PM, Alexey Semenyuk wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> Additionally removed code that adds component to msi package to 
>> remove files and directories not managed by the msi package in 
>> shortcuts folder (changes in WixSourcesBuilder.java).
>>
>> - Alexey
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8233138
>>
>> [2] http://cr.openjdk.java.net/~asemenyuk/8233138/webrev.00
>>
>