RFR of JDK-8134599: TEST_BUG: java/rmi/transport/closeServerSocket/CloseServerSocket.java fails intermittently with Address already in use

sha.jiang at oracle.com sha.jiang at oracle.com
Wed Sep 4 03:33:37 UTC 2019


Hi Hamlin,

66         Thread.sleep(1000L * (long)TestLibrary.getTimeoutFactor());
Now that the factor has been casted to long, it could just use 1000 
instead 1000L.

Could the fraction of this factor value be greater than 0?
If so, the casting should take effect after the multiplication, like
Thread.sleep((long) (1000 * TestLibrary.getTimeoutFactor()));

Best regards,
John Jiang

On 2019/9/4 11:01, Hamlin Li wrote:
> Hi,
>
> Would you please review the following patch?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8134599
>
> webrev: http://cr.openjdk.java.net/~mli/8134599/webrev.00/
>
>
> Thank you
>
> -Hamlin
>
>


More information about the core-libs-dev mailing list