[14] RFR: 8229831: Upgrade Character.isUnicodeIdentifierStart/Part() methods to the latest standard

Roger Riggs Roger.Riggs at oracle.com
Wed Sep 4 20:54:41 UTC 2019


Hi Naoto,

The CSR looks ok.

In Character.java:

In the descriptions mentioning VERTICAL TILDE, I would drop the word 
"solely".
for example,

* {@code 'VERTICAL TILDE'} is added to {@code Start} for backward
* compatibility.

Overall looks like a good update.

Roger




On 8/29/19 3:42 PM, naoto.sato at oracle.com wrote:
> Hi,
>
> Please review the proposed modifications to the methods in 
> java.lang.Character class. The CSR is located here:
>
> https://bugs.openjdk.java.net/browse/JDK-8230188
>
> It mainly intends to clarify the spec of the Unicode Identifier 
> methods, by supplying the corresponding Unicode Standard Annex #31 
> explanations. Also, it intends to upgrade the current implementation 
> to the latest 12.0 level. Here is the proposed implementation changes:
>
> https://cr.openjdk.java.net/~naoto/8229831/webrev.00/
>
> The CSR is intentionally left as draft so that I can gather/reflect 
> opinions from this list.
>
> Naoto



More information about the core-libs-dev mailing list