RFR: JDK-8230519: jpackage "--package-type" values and default

Andy Herrick andy.herrick at oracle.com
Mon Sep 9 19:17:10 UTC 2019


On 9/9/2019 1:25 PM, Alexey Semenyuk wrote:
> http://cr.openjdk.java.net/~herrick/8230519/webrev.01/test/jdk/tools/jpackage/share/RuntimeTest.java.sdiff.html: 
>
> ---
> 37         "--package-type", "app-image",
> 38         "--package-type", "app-image",
> ---
> Duplication by accident?
yes - will fix.
>
> http://cr.openjdk.java.net/~herrick/8230519/webrev.01/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java.sdiff.html: 
>
> ---
> // we are just going to run "dpkg -s coreutils" ans assume Debian
> ---
> "ans" - typo? Should it be "and"?
yes - will fix
>
> - Alexey
>
> On 9/8/2019 5:50 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> This fix:
>>
>> Adds "app-image" as a valid value for "--package-type" options, 
>> meaning build an application image instead of a package.
>>
>> Changes the default value of "--package-type" to a platform dependent 
>> default package type.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8230519
>> [2] http://cr.openjdk.java.net/~herrick/8230519/webrev.01/
>>
>> Thanks
>>
>> Andy,
>>
>


More information about the core-libs-dev mailing list