RFR: 8230648: Replace @exception tag with @throws in java.base
Julia Boes
julia.boes at oracle.com
Wed Sep 18 14:20:20 UTC 2019
Hi Daniel,
That sounds good, thank you. The copyright year update is made. Please
note that there are a few cases where the whitespace after the @throws
tag is less than three to align it with its neighboring tags, e.g.
BufferedOutputStream line 65.
Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8230648/webrev.03/
Cheers,
Julia
On 18/09/2019 12:27, Daniel Fuchs wrote:
> Hi Julia,
>
> I will be sponsoring this change, since you got a positive review
> from both Lance and Pavel I believe we can now push it.
>
> Can you prepare a changeset that can be hg-imported, including
> the copyright year updates that were asked for? I'll try to push
> it later today - unless there's any further objection.
>
> best regards,
>
> -- daniel
>
> On 06/09/2019 12:33, Pavel Rappo wrote:
>> If you ran the specdiff and saw nothing, I'm fine with that. Looks good.
>
>
> On 06/09/2019 12:23, Lance Andersen wrote:
>> Hi Julia,
>>
>> It looks fine., thank you for doing this
>>
>>
>> Best
>> Lance
>>> On Sep 5, 2019, at 2:28 PM, Julia Boes <julia.boes at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Thanks for your comments, Lance and Pavel.
>>>
>>> The copyright will be updated before pushing, as Daniel suggested.
>>>
>>> To address the tag alignment, I adjusted the replacement from
>>> '@exception' -> '@throws' to '@exception' -> 'throws ', where the
>>> added whitespace preserves the original alignment. This doesn't
>>> improve the alignment (which is not consistent in many places) but
>>> at least doesn't make it worse.
>>>
>>> Updated webrev:
>>> http://cr.openjdk.java.net/~dfuchs/jboes/8230648/webrev.02/
>>>
>>> Regarding Pavel's comment:
>>>
>>> 8157682: @inheritDoc doesn't work with @exception
>>>
>>> I ran specdiff on the whole JDK and it didn't flag any differences
>>> but I'll look into additional comparison options.
>>>
>>> Cheers,
>>>
>>> Julia
>>>
>>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>
More information about the core-libs-dev
mailing list