[8u] RFR: 8142543: Unformatted code example in API
Evgeny Mandrikov
mandrikov at gmail.com
Wed Sep 18 20:23:22 UTC 2019
On Wed, Sep 18, 2019 at 9:38 PM Aleksey Shipilev <shade at redhat.com> wrote:
> On 9/18/19 9:29 PM, Evgeny Mandrikov wrote:
> > Hello,
> >
> > Please review this 8u backport [1] of JDK-8073347 [2] that resolves
> > JDK-8142543 [3].
>
> Wait, that's not how it works, sorry. Please read this:
> https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
>
> Since you are backporting 8073347, you need to start there. It would be
> backported by the same bug
> ID (8073347), not the one you are proposing here (8073347). The patch
> itself looks okay, but you
> need to do this per process (see above). Chances are, it would not even
> need an RFR, on the
> off-chance it applies cleanly.
>
Oups, I discovered first 8142543, then 8073347, then tried to follow same
process as used year ago but which was requiring modification of original
patch. Now I see the difference. Thank you for the link.
So AFAIU from the above wiki page - first 8142543 should be closed as dup
of 8073347, then 8073347 should be labeled jdk8u-fix-request with a comment
like
Fix Request (jdk8u)
Patch is trivial (documentation-only). Only slight path modification is
required due to repo-consolidation past 8u, after which patch applies
cleanly.
?
Regards,
Evgeny
More information about the core-libs-dev
mailing list