RFR [14/java.xml] 8231083: Clarify SAX documentation

Lance Andersen lance.andersen at oracle.com
Fri Sep 20 00:18:34 UTC 2019


Hi Joe,

Overall this looks good and also cleans up a couple of typos :-)

One nit in both package-info @apiNote, you will notice an extra space before the was which could be removed before you push

Best
Lance
> On Sep 19, 2019, at 8:00 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> 
> Please review a follow-up doc clarification patch after 8230814 [1]. In this patch, the statement with a reference to the SAX project is moved to an apiNote in package/sub-package description to reflect the fact that it is a historical note in nature. The license related text that appears in the class description of every SAX class is removed and consolidated with the existing text in the license header.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8231083
> webrev: http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev/index.html
> 
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8230814
> 
> Thanks,
> Joe

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list