JDK 14 RFR of JDK-8199424: consider removing ObjectInputStream and ObjectOutputStream native methods

[Roger Riggs]

Hi Joe,

Looks good, thanks for the cleanup.

Roger


On 9/19/19 11:02 PM, Joe Darcy wrote:
> Hi Brian,
>
> Now including ObjectInputStream changes:
>
>      http://cr.openjdk.java.net/~darcy/8199424.1/
>
> Serialization regression tests still all pass.
>
> Thanks,
>
> -Joe
>
> On 9/19/2019 5:19 PM, Brian Burkhalter wrote:
>> Hi Joe,
>>
>> This looks good. Will there be a similar separate patch for 
>> ObjectInputStream?
>>
>> Brian
>>
>>> On Sep 19, 2019, at 3:34 PM, Joe Darcy <joe.darcy at oracle.com 
>>> <mailto:joe.darcy at oracle.com>> wrote:
>>>
>>> As part of my serialization work, I noticed some "to do" notes in 
>>> ObjectOutputStream.java to get rid of two native methods once the 
>>> integral <-> floating-point bitwise conversion methods 
>>> (Float.floatToIntBits, etc.) were intrinsified. That 
>>> intrinsification occurred many releases back and the recommended 
>>> cleanup can be done now. Pre-existing bug for this issue:
>>>
>>>      JDK-8199424 : consider removing ObjectInputStream and 
>>> ObjectOutputStream native methods
>>> http://cr.openjdk.java.net/~darcy/8199424.0/
>>>
>>> Note the logic controlling for copying the float bytes is the same 
>>> as the logic for copying the int bytes as both int and float are 4 
>>> bytes, same relationship between the copying of double and long bytes.
>>