RFR [14/java.xml] 8231083: Clarify SAX documentation
Joe Wang
huizhe.wang at oracle.com
Fri Sep 20 16:05:58 UTC 2019
Thanks Lance! It's a cleanup on top of cleanup :-)
On 9/20/19 4:13 AM, Lance Andersen wrote:
> Round 2 even looks cleaner :-)
>
>
>> On Sep 20, 2019, at 1:15 AM, Joe Wang <huizhe.wang at oracle.com
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Thanks Lance!
>>
>> Yes, saw them typos :-) Also removed the extra space in apiNote.
>>
>> Updated webrev below, with removing the text in the javadoc instead
>> of moving to the header.
>> http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev/index.html
>>
>> -Joe
>>
>> On 9/19/19 5:18 PM, Lance Andersen wrote:
>>> Hi Joe,
>>>
>>> Overall this looks good and also cleans up a couple of typos :-)
>>>
>>> One nit in both package-info @apiNote, you will notice an extra
>>> space before the was which could be removed before you push
>>>
>>> Best
>>> Lance
>>>> On Sep 19, 2019, at 8:00 PM, Joe Wang <huizhe.wang at oracle.com
>>>> <mailto:huizhe.wang at oracle.com>> wrote:
>>>>
>>>> Please review a follow-up doc clarification patch after 8230814
>>>> [1]. In this patch, the statement with a reference to the SAX
>>>> project is moved to an apiNote in package/sub-package description
>>>> to reflect the fact that it is a historical note in nature. The
>>>> license related text that appears in the class description of every
>>>> SAX class is removed and consolidated with the existing text in the
>>>> license header.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8231083
>>>> webrev:
>>>> http://cr.openjdk.java.net/~joehw/jdk14/8231083/webrev/index.html
>>>>
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8230814
>>>>
>>>> Thanks,
>>>> Joe
>>>
>>> <oracle_sig_logo.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
More information about the core-libs-dev
mailing list