RFR 8231314: java.time serialization warning cleanup
Joe Darcy
joe.darcy at oracle.com
Fri Sep 20 21:40:25 UTC 2019
Hello,
Looks fine to me too. As Naoto observed, the patch is on top of a
changeset with annotations I haven't pushed yet; I think it would be
fine if this changeset were pushed first and I'll adjust mine accordingly.
Thanks,
-Joe
On 9/20/2019 2:03 PM, naoto.sato at oracle.com wrote:
> Hi Roger,
>
> Looks good to me.
>
> There are some removed "@SuppressWarnings("serial")" which don't exist
> in the current JDK14 code base, e.g., line 115 of java/time/Ser.java,
> but I assumed they can be safely ignored.
>
> Naoto
>
> On 9/20/19 11:51 AM, Roger Riggs wrote:
>> Please review code cleanup that will remove the need to suppress soon
>> to be introduced
>> warnings [1] about static typing of serialization related fields.
>> A few of the implementation Ser classes that serialize java.time
>> types are affected.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-warn-serializable-8231314/
>>
>> Thanks, Roger
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8231202
>>
>>
More information about the core-libs-dev
mailing list