RFR: JDK-8230927 : Wrong arguments set for additional launchers

[Andy Herrick]

Revision 2 or the webrev ( [3] )  removes the comment about 
`--linux-deb-copyright-file` option., replaces the literal strings with 
the CLIOptions id's, and adds unit test to AddLauncherTest.java

[3] http://cr.openjdk.java.net/~herrick/8230927/webrev.02/

/Andy

On 9/24/2019 9:19 AM, Alexey Semenyuk wrote:
> Andy,
>
> Please remove javadoc update about `--linux-deb-copyright-file` 
> option. It will be dropped in 
> https://bugs.openjdk.java.net/browse/JDK-8231277 patch.
> Line 180:
> ---
> if (additional.containsKey("java-optiions")) {
> ---
> Looks like a typo. Should be "java-options", not "java-optiions", I 
> guess.
> We probably need a test or at least a follow up CR to track the task 
> of adding a test for "java-options" parameter in additional launchers.
>
> - Alexey
>
> On 9/24/2019 8:46 AM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> This change applies when arguments or java-options are used in an 
>> add-launcher properties file.
>>
>> In these cases the arguments or java-options from the properties 
>> files should replace instead of being added to the same options used 
>> in the command line  for the main launcher.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8230927
>>
>> [2] http://cr.openjdk.java.net/~herrick/8230927
>>
>> /Andy
>>
>