RFR 8221623 : Add StackWalker micro benchmarks to jdk repo
Brent Christian
brent.christian at oracle.com
Tue Sep 24 20:01:26 UTC 2019
On 9/23/19 4:48 PM, Mandy Chung wrote:
>
> I think doing the measurement for one of these would be adequate.
>
> StackWalkBench.forEach_AllOpts
> StackWalkBench.forEach_DefaultOpts
> StackWalkBench.forEach_HiddenAndReflectFrames
OK, reduced to just DefaultOpts.
> There are a couple of commented benchmarks. Should they be taken out?
Sure; testGoThereBH() was from some early experimenting and is not
needed - removed.
The getCallerClass() tests in ThrowableRuntimeMicros served as a
reminder that they need updating, but having JDK-8230976 filed is
sufficient.
IMO, it would be nice to have the PerfCounter example in StackWalkBench
ready-to-uncomment, in case it's needed again sometime.
>> Though really, since logging is no longer using Throwable to examine
>> the call stack, maybe it makes more sense to move the logging
>> benchmarks to their own file under:
>>
>> test/micro/org/openjdk/bench/java/util/logging/
>
> That seems a good idea.
Yes, those are moved.
http://cr.openjdk.java.net/~bchristi/8221623/webrev11/
Thanks,
-Brent
More information about the core-libs-dev
mailing list