RFR: JDK-8230649 : Make jpackage tool an experimental feature

[Kevin Rushforth]

That seems fine then. Thanks.

-- Kevin


On 9/25/2019 8:29 AM, Andy Herrick wrote:
> I can will remove the makefile change then.
>
> The warning is going the same place as the help output (Log.info()) 
> which is stdout unless a different stream is passed to ToolProvider.
>
> So if we want a more detailed message in Help text we can either show 
> the more detailed message in addition to the message shown in all 
> cases, or specifically exclude the generic message in the Help case.
>
> /Andy
>
> On 9/25/19 11:18 AM, Kevin Rushforth wrote:
>>
>>
>> On 9/25/2019 7:44 AM, Alan Bateman wrote:
>>> On 25/09/2019 15:33, Andy Herrick wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> These are the code changes to make jpackage an experimental feature.
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8230649
>>>>
>>>> [2] http://cr.openjdk.java.net/~herrick/8230649/webrev.02/
>>> I assume the change to CreateJmods.gmk is not needed as the module 
>>> will be resolved because it provides an implementation of ToolProvider.
>>
>> I was going to point out the same thing as Alan. The rest looks good, 
>> although an explicit informational line in the --help message might 
>> be nice, in case log warnings are going somewhere else.
>>
>> -- Kevin
>>