RFR [15] 8242230: Whitespace typos, relaxed javadoc, formatting

Ivan Gerasimov ivan.gerasimov at oracle.com
Tue Apr 7 08:11:35 UTC 2020


Hi Pavel!

A couple of comments.

1)
java/util/logging/Formatter.java

This has one extra open curly brace:

"{{@literal <digit>}"

2)
grep finds some more typos of the same kind that you've spotted.

a)  rgrep '^[ ]*\*'|grep ' ,'|less

This find number of potential typos.  For example, the javadoc for 
VarHandle [1] has 53 occurrances of space-before-comma.  A few more are 
found in j.l.Thread, j.io.DataOutput, j.l.String, etc.

b)  rgrep '^[ ]*\*'|grep '\w- '|less

This find the word 'network' broken with a hyphen at [2] and also in 
share/classes/sun/net/util/IPAddressUtil.java

(I only searched under src/java.base)

With kind regards,

Ivan

[1] 
https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/lang/invoke/VarHandle.html

[2] 
https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/net/Inet4Address.html

On 4/6/20 11:28 AM, Pavel Rappo wrote:
> Hello,
>
> Please review the change for https://bugs.openjdk.java.net/browse/JDK-8242230:
>
>    http://cr.openjdk.java.net/~prappo/8242230/webrev.00/
>
> This is a documentation cleanup. There are no code changes involved,
> and the changes in documentation are mostly trivial.
>
> The following packages are affected:
>
>      java.lang,
>      java.text,
>      java.util,
>      java.util.logging,
>      javax.lang.model.util,
>      jdk.internal.reflect
>
> -Pavel
>
-- 
With kind regards,
Ivan Gerasimov



More information about the core-libs-dev mailing list