JarFile.getVersionedEntry scalability with new release cadence
Eirik Bjørsnøs
eirbjo at gmail.com
Tue Apr 14 08:59:07 UTC 2020
On Tue, Apr 14, 2020 at 10:15 AM Alan Bateman <Alan.Bateman at oracle.com>
wrote:
Would it be possible to send an updated webrev with the patch that is
> proposed for jdk/jdk?
My understanding is that Claes may initiate a formal review once my OCA is
processed and he's done some testing.
> One thing that I'm concerned about is that
> META-INF/* is a JAR file concepts and I'd prefer not build up further
> shared secrets that operate on ZipFile (should be consistent JarFile and
> JarEntry when dealing with JAR files).
>
True. META-INF/ semantically belongs in JarFile. The reasons for moving the
parsing logic to ZipFile.Source were:
1: Scanning of META-INF/ entries already happens there and scanning
META-INF/versions/ is tightly related to this (it's a sub-problem).
2: Acceptable performance requires that we keep parsing on the byte[]
level, without String conversions. The CEN isn't directly available in
binary from from JarFile.
Eirik.
More information about the core-libs-dev
mailing list