RFR: 8241055: Regex Grapheme Matcher Performance Depends too much on Total Input Sequence Size

[naoto.sato at oracle.com]

Hi Philipp,

Thanks for the update. I like you enriched the RegExTest.java. Two nits:

- RegExTest.java at line 4805: I'd use parentheses for this return 
statement.

- PatternBench.java should keep the original copyright year, i.e., 
"2020," -> "2019, 2020,"

Otherwise, it looks good.

Naoto

On 4/14/20 9:26 AM, Philipp Kunz wrote:
> Hi Naoto,
> 
> I agree, see attached patch.
> 
> Regards,
> Philipp
> 
> 
> On Thu, 2020-03-26 at 14:14 -0700, naoto.sato at oracle.com wrote:
>> Hi Philipp,
>>
>> I looked at the patch, and it looks good to me. As to the test case,
>> since it is measuring the performance, I would make it in a JMH test.
>> Maybe you would want to put it similar to
>> open/test/micro/org/openjdk/bench/java/util/regex/PatternBench.java
>>
>> Minor suggestion: I would rather rename "getGraphemeType()" to just
>> "getType()", as it is simply retrieving the character type.
>>
>> Naoto
>>
>> On 3/21/20 7:58 AM, Philipp Kunz wrote:
>>> Hi,
>>>
>>> Any opinions on the attached patch or someone tempted to sponsor it?
>>>
>>> Regards,
>>> Philipp