RFR: JDK-8232935: jpackage failed with NPE whenever --file-associations provided
Alexander Matveev
alexander.matveev at oracle.com
Wed Apr 15 20:21:09 UTC 2020
Hi Alexey,
http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources.properties.frames.html
Line 58-59: I think we do not need "." at the end of error messages to
make it same as other messages.
Do we need to call
FileAssociation.verify(FileAssociation.fetchFrom(params)); for Mac?
Otherwise looks fine.
Thanks,
Alexander
On 4/15/20 1:10 PM, Alexey Semenyuk wrote:
> I've updated the webrev. No more unexpected changes.
>
> - Alexey
>
> On 4/15/2020 3:18 PM, Alexey Semenyuk wrote:
>>
>>
>> On 4/15/2020 2:36 PM, Andy Herrick wrote:
>>> The change looks good, but I am confused why Japanese and Chinese
>>> MainResources property files show a lot of changes that seem to be
>>> no change.
>> Good catch. Seems like my text editor replaced upper case letters in
>> character codes with lower case creating this mess. I'll fix this and
>> update the webrev.
>>
>> - Alexey
>>>
>>>
>>> On 4/15/2020 2:13 PM, Alexey Semenyuk wrote:
>>>> Please review fix [2] for jpackage bug [1].
>>>>
>>>> Move function checking values of mime types in file associations
>>>> from Linux to shared code. Added jtreg tests to cover use cases
>>>> when no or multiple mime types are specified for file associations.
>>>>
>>>> - Alexey
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8232935
>>>>
>>>> [2] http://cr.openjdk.java.net/~asemenyuk/8232935/webrev.00
>>>>
>>
>
More information about the core-libs-dev
mailing list