RFR (T): 8243117: Cleanups in Java code of module jdk.jlink

Langer, Christoph christoph.langer at sap.com
Tue Apr 21 07:47:10 UTC 2020


Hi Alan,

> >> Looks okay to me too, except @SuppressWarnings("unused") looks
> strange,
> >> is that an Eclipse compiler warning name?
> > Yes, it comes from Eclipse, probably only used by its compiler. The private
> field EXIT_SYSERR doesn't seem to be used. Alternatively, I could comment it
> out? Or remove it?
> >
> The jimage tool went through a few iterations and I think it's just a
> left over and should be okay to remove.

OK, I'll remove it altogether then: http://cr.openjdk.java.net/~clanger/webrevs/8243117.1/

I'll push it tomorrow, after a final round of testing.

Cheers
Christoph



More information about the core-libs-dev mailing list