[15] RFR: 8242614: cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests

Aleks Efimov aleksej.efimov at oracle.com
Tue Apr 21 09:15:26 UTC 2020


Hi Chris,

The changes looks good to me. Thanks for improving the tests!

It's nice to see dummy LDAP servers replaced by the common test server 
skeleton.

With Best Regards,
Aleksei

On 21/04/2020 08:43, Chris Yin wrote:
> Hello
>
> Please review following changes to cleanup duplicated test ldap server in some com/sun/jndi/ldap/ tests, thanks
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8242614
> Webrev: http://cr.openjdk.java.net/~xyin/8242614/webrev.00/
>
> This is the first part to cleanup straightforward duplicated test ldap server which was embedded in test itself. In the past, ldap tests may copy or implemented a dummy server in test itself to support specific test logic, so we have many duplicated dummy server logic across tests. Now there is already a common test ldap server skeleton available, it’s time to cleanup those duplicated logic to reduce possible future maintenance works. Run modified tests on 4 platforms for total 200 times, all green.
>
> Thanks,
> Chris



More information about the core-libs-dev mailing list