RFR 15: 8243010: Test support: Customizable Hex Printer

Lance Andersen lance.andersen at oracle.com
Thu Apr 23 19:32:00 UTC 2020


Hi Roger,

Sorry, I thought I replied.  I think this looks good and I look forward to using it more going forward.

+1 from me

Best
Lance

> On Apr 23, 2020, at 2:46 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> Ping...
> 
> I appreciate the comments about extending the functionality and uses and will take them up as a separate enhancement.
> 
> A review would be appreciated.
> 
> Thanks, Roger
> 
> 
> On 4/16/20 3:17 PM, Roger Riggs wrote:
>> Please review[2] and comment on a new Hex printing utility to support OpenJDK tests.
>> The usefulness of a hex printing has been discussed from time to time with
>> many suggestions as to the API shape and features.
>> 
>> To get an idea of the API and features, take a look at the javadoc[1].
>> It covers the basic formatting of offset, and values, and extends the
>> descriptive part beyond simple ASCII or printable so that a custom formatter
>> can interpret the byte stream in parallel to the bytes.
>> 
>> The webrev includes changes to existing tests that currently
>> use HexDumpEncoder to use HexPrinter.
>> 
>> Comments appreciated, Roger
>> 
>> [1]Javadoc:
>> http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8243010/javadoc
>> 
>> [2] Webrev:
>>   http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8243010/
>> 
>> [3] Issue:
>>   https://bugs.openjdk.java.net/browse/JDK-8243010
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list