RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

[David Holmes]

Hi Bin,

On 24/04/2020 7:28 pm, buddyliao(廖彬) wrote:
> Dear all,
> 
> As Lin mentioned, I found the copyright info is not updated, so I prepared a patch to fix this. Lin helps me to build an issue in the jdk bug system. Would you help me to review this patch? Thank you very much.
> Patch link: https://cr.openjdk.java.net/~lzang/BuddyLiao/launcher/webrev/
> Issue link: https://bugs.openjdk.java.net/browse/JDK-8243539

Please create a new RFR email thread for this follow up issue.

Thanks,
David

> BRs,
> Bin
> 
> 
> 在 2020/4/24 上午10:38，“linzang(臧琳)”<linzang at tencent.com> 写入:
> 
>      Hi Henry, Alan, David
>              My colleague Bin(Buddy) just remind me that the copyright info of the touched files should be updated, sorry that I  forgot to add it in my original patch , do you think there should be a patch for fixing that?
>      
>      BRs,
>      Lin
>      
>      On 2020/4/7, 4:56 PM, "Alan Bateman" <Alan.Bateman at oracle.com> wrote:
>      
>          On 06/04/2020 18:36, Henry Jen wrote:
>          > Here is the combined webrev[1] which I think is what we should have. By using __solaris__, we make sure no extra define from build and assuming that all solaris build will have gethrtime() and use that.
>          >
>          > The current build only use that for static build launcher, not custom launcher use libjli.
>          >
>          > Cheers,
>          > Henry
>          >
>          > [1] http://cr.openjdk.java.net/~henryjen/jdk/8241638.2/webrev/
>          >
>          I think it would be simpler to drop the macros and have function
>          prototypes in java_md_sollinux.h. That would avoid preprocessor code in
>          the header file. The implementation in java_md_sollinux.c would then be
>          simple #ifdef __solaris ... #else ... Minor nit is that the #include
>          <sys/time.h> should probably be moved up to the top with the other includes.
>      
>          -Alan.
>      
>      
>      
>