RFR: 8243648: Windows 32bit compile error src/jdk.incubator.jpackage/windows/native/libjpackage/VersionInfo.cpp

Baesken, Matthias matthias.baesken at sap.com
Tue Apr 28 06:55:54 UTC 2020


Hello,  please review this small fix for  the  windows 32bit build .


Currently we run into this compile error on Windows :
./src/jdk.incubator.jpackage/windows/native/libjpackage/VersionInfo.cpp(123): error C2220: warning treated as error - no 'object' file generated
./src/jdk.incubator.jpackage/windows/native/libjpackage/VersionInfo.cpp(123): warning C4244: 'argument': conversion from 'std::streamoff' to 'size_t', possible loss of data

(after 8236129 was pushed)

On windows 32bit we have

typedef long streamoff

according to

https://docs.microsoft.com/en-us/cpp/standard-library/ios-typedefs?view=vs-2019

so we had issues with the size_t conversion .

Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8243648

http://cr.openjdk.java.net/~mbaesken/webrevs/8243648.0/

Thanks, Matthias


More information about the core-libs-dev mailing list