RFR 8243491: Implementation of Foreign-Memory Access API (Second Incubator)

[Maurizio Cimadamore]

Looks good - thanks. Perhaps I'd tweak "will hold" and replace it with 
"will feature", and also add a link between "access modes" to the access 
mode section of the javadoc, to make it more navigable.

Maurizio


On 30/04/2020 14:33, Chris Hegarty wrote:
> Maurizio,
>
>> On 23 Apr 2020, at 21:33, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
>>
>>
>> Javadoc:
>>
>> http://cr.openjdk.java.net/~mcimadamore/8243491_v2/javadoc
>>
> I’m still working my way through this update ( BTW it’s looking very good ), but an initial comment on the API.
>
> The access modes of MemorySegment are a nice addition, but while reading the API alone, I find myself wondering what access modes are held by segments returned by the static factories. Most hold all access modes but not all, e.g. read-only byte buffer. AND a mapped segment with mapping mode READ_ONLY ?
>
> Maybe it is worth specifying this? E.g something like:
>    https://cr.openjdk.java.net/~chegar/foreign/segmentAccessModes/
>
> -Chris.