RFR: JDK-8244018: No error message for non-existent icon path

Alexander Matveev alexander.matveev at oracle.com
Thu Apr 30 23:58:48 UTC 2020


Hi Andy,

Looks good.

Thanks,
Alexander

On 4/30/20 4:18 PM, Andy Herrick wrote:
> revised webrev at [3] - copyrights were updated by previous issue.
>
> /Andy
>
> [3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/
>
> On 4/29/2020 4:56 PM, Alexander Matveev wrote:
> Hi Andy,
>
> http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources_ja.properties.frames.html 
>
> http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources_zh_CN.properties.frames.html 
>
> Typo in year: 20120 -> 2020
>
> Otherwise looks fine.
>
> Thanks,
> Alexander
>
> On 4/29/20 7:31 AM, Andy Herrick wrote:
>> Please review fix at [1] for issue [2]
>>
>> The change just adds error when specified icon is not found, and a 
>> test for that.
>>
>> /Andy
>>
>> [1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/
>>
>> [2] - https://bugs.openjdk.java.net/browse/JDK-8244018
>>
>>



More information about the core-libs-dev mailing list