RFR 8251202: Add missing javadoc comments
Lance Andersen
Lance.Andersen at oracle.com
Fri Aug 7 00:04:56 UTC 2020
Hi Naoto
Thank you for catching that
Will add them before I push the change
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPhone
> On Aug 6, 2020, at 7:35 PM, naoto.sato at oracle.com wrote:
>
> Looks good, Lance.
>
> nit: a couple of comments (line 128,133) don't end with periods.
>
> Naoto
>
>> On 8/6/20 3:32 PM, Lance Andersen wrote:
>> Hi all,
>> Please review the webrev for: https://bugs.openjdk.java.net/browse/JDK-8251202 <https://bugs.openjdk.java.net/browse/JDK-8251202>, which adds missing javadoc comments to java.util.zip.ZipConstants.
>> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8251205/webrev.00/
>> The CSR, which has been approved, can be found at: https://bugs.openjdk.java.net/browse/JDK-8251206 <https://bugs.openjdk.java.net/browse/JDK-8251206>
>> Best
>> Lance
>> ------------------
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
More information about the core-libs-dev
mailing list