RFR: 8248905: [macos] symbolic links not properly resolved

Alexey Semenyuk alexey.semenyuk at oracle.com
Fri Aug 7 22:36:42 UTC 2020


Looks good. Minor suggestion, please change
---
tstring getRealPath(std::vector<char> in)
---
to
---
tstring getRealPath(const std::vector<char>& in);
---

- Alexey

On 8/7/2020 5:54 PM, alexander.matveev at oracle.com wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> - Fixed by converting path of executable to real path if 
> _NSGetExecutablePath() returned symbolic link.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8248905
> [2] http://cr.openjdk.java.net/~almatvee/8248905/webrev.00/
>
> Thanks,
> Alexander



More information about the core-libs-dev mailing list