RFR 8251208: Fix javadoc warnings in java.sql and java.sql.rowsets

[Joe Wang]

Looks good, Lance.

Nothing can't be solved with a cup of coffee ;-)

Best,
Joe

On 8/14/20 10:43 AM, Lance Andersen wrote:
> Hi Joe,
>
> Thank you for the review.
>
> Changes had been made to the typos below (went back to far in IntelliJ 
> fixing another issue :-( )
>
> CSR has also been updated to fix the typos (missed I guess due to lack 
> of coffee this am ;-) )
>
> http://cr.openjdk.java.net/~lancea/8251208/webrev.01/index.html is the 
> updated webrev
>
> Best
> Lance
>
>> On Aug 14, 2020, at 1:20 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Hi Lance,
>>
>> Looks good to me overall.
>> *
>> **Minor typos in the CSR:*
>> Address the Fix "no comment" warnings in java.sql and 
>> java.sql.rowsetsgenerated by javadoc -Xdoclint
>>             ^ remove Fix                                              
>> ^ missing a spacebetween rowsetsgenerated
>>
>> java.sql and java.sql.rowset contain several iclasses
>> classes
>>
>> Compatibility Risk: the last word "clas" -> class
>>
>> *Webrev:*
>> Need to update copyright year for classes: SerialRef.java, 
>> SerialStruct.java, SQLClientInfoException.java
>>
>> StatementEvent.java: the 1st statement (line 47) was supposed for the 
>> 2nd field (line55), while the 2nd (line 52) for the 1st (line 49) :-)
>>             e.g.:
>>  46         /**
>> 47 * The {@code PreparedStatement} that is being closed or is invalid.
>>  48          */
>>  49 private SQLException            exception;
>>  50
>>  51         /**
>>  52 * The {@code SQLException} the driver is about to throw to the 
>> application.
>>  53          */
>>  54 @SuppressWarnings("serial") // Not statically typed as Serializable
>>  55 private PreparedStatement       statement;
>>
>>
>> -Joe
>>
>> On 8/14/2020 3:37 AM, Lance Andersen wrote:
>>> Hi all,
>>>
>>> Please review the fix to address javadoc warnings in java.sql and java.sql.rowsets
>>>
>>> The webrev can be found at:http://cr.openjdk.java.net/~lancea/8251208/webrev.00/
>>>
>>> And the CSR at:https://bugs.openjdk.java.net/browse/JDK-8251834
>>>
>>> Best
>>> Lance
>>> ------------------
>>>
>>>
>>>
>>>
>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com
>>>
>>>
>>>
>>>
>>
>
>
> Best
> Lance
> ------------------
>
>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
>