RFR 8251203: Fix "no comment" warnings in java.base/java.lang and java/io

Roger Riggs Roger.Riggs at oracle.com
Fri Aug 21 16:52:41 UTC 2020


Thanks for the reviews.

The copyright dates are updated in the webrev:
     http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-2/

The @serial javadoc tag is used on any serialization related field or 
method.
Are there some missing? I expect javac would warn if they were missing.

Thanks, Roger


On 8/21/20 12:06 PM, Daniel Fuchs wrote:
> On 21/08/2020 16:09, Roger Riggs wrote:
>> Please review the addition of comments to classes and fields to resolve
>> javadoc "no comment" warnings in the java.lang and java.io packages.
>> The comments are derived from the existing behavior and context.
>
> Looks good to me Roger.
>
> I don't quite recall when the @serial javadoc tag should be used.
> That is - should it be used when documenting a non transient
> private field in the absence of serialPersistentFields ?
>
> best regards,
>
> -- daniel
>
>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-nocomment-8251203-1/
>>
>> CSR:
>>      https://bugs.openjdk.java.net/browse/JDK-8252129
>>
>> Issue:
>>      https://bugs.openjdk.java.net/browse/JDK-8251203
>>
>> Thanks, Roger
>>
>>
>



More information about the core-libs-dev mailing list