Review request for JDK-8251538: Modernize and lint Dynalink code
sundararajan.athijegannathan at oracle.com
sundararajan.athijegannathan at oracle.com
Thu Aug 27 02:30:50 UTC 2020
Looks good. Thanks for doing this cleanup!
-Sundar
On 21/08/20 2:10 am, Attila Szegedi wrote:
> Following up on the previous e-mail, here’s the modernization and linting work on the existing Dynalink codebase:
>
> Please review JDK-8251538 "Modernize and lint Dynalink code" at <http://cr.openjdk.java.net/~attila/8251538/webrev.jdk16> for <https://bugs.openjdk.java.net/browse/JDK-8251538>
>
> The Jira issue has a full enumeration of kinds of changes I did here; they’re mostly all source text removals :-)
>
> Oh, BTW, I really got an inspiration for adding “public static ClassValue<T> computingValue(Function<Class<?>, T> f)” method to ClassValue class, similar to Comparator.comparing. It’d allow lambdifying class values. (If you’re listening, John :-) I suspect it being in java.lang would be a JCP-level change so I kind-of don’t want to take it upon myself…)
>
> Thanks,
> Attila.
>
More information about the core-libs-dev
mailing list