RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

Fernando Guallini fernando.guallini at oracle.com
Thu Aug 27 15:41:39 UTC 2020


Thanks Sean, updated webrev here: http://cr.openjdk.java.net/~fguallini/8249699/webrev.01/

Regards,
Fernando
----- Original Message -----
From: sean.coffey at oracle.com
To: fernando.guallini at oracle.com, core-libs-dev at openjdk.java.net
Sent: Wednesday, 26 August, 2020 7:39:25 PM GMT +00:00 GMT Britain, Ireland, Portugal
Subject: Re: RFR: JDK-8249699: java/io/ByteArrayOutputStream/MaxCapacity.java should use @requires instead of @ignore

test/jdk/java/util/Base64/TestEncodingDecodingLength.java is an example 
of another test using -Xmx8g. Do you want to push the os.maxMemory 
requirement up to 10g perhaps ? It might avoid border line resource 
failures. Also I think it might need a "sun.arch.data.model == "64" " 
requirement :

@requires (sun.arch.data.model == "64" & os.maxMemory >= 10g)

regards,
Sean.

On 26/08/2020 18:17, Fernando Guallini wrote:
> Hi,
>
> Could I please get reviews and a sponsor for:
>
> webrev: http://cr.openjdk.java.net/~fguallini/8249699/webrev.00/ <http://cr.openjdk.java.net/~fguallini/8249699/webrev.00/>
> Testbug: https://bugs.openjdk.java.net/browse/JDK-8249699 <https://bugs.openjdk.java.net/browse/JDK-8249699>
>
> The test was ignored due to ‘huge memory requirements’, but with the jtreg current version, tests can be only run when system requirements are satisfied as opposed to being always excluded. It runs and passes in Mach5
>
>
> Thanks
>
> -Fernando


More information about the core-libs-dev mailing list