Integrated: 8255542: Attribute length of Module, ModulePackages and other attributes is ignored
Alan Bateman
alanb at openjdk.java.net
Fri Dec 4 09:02:54 UTC 2020
On Tue, 24 Nov 2020 10:58:43 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> The attribute_length of known ModuleXXXX attributes in the module-info.class is currently ignored. It should be checked and the class rejected if the attribute length doesn't exactly match the length of the info in the attribute.
>
> There are several ways to fix this. I initially limited the reading of the attribute_info to the attribute length but this resulted in confusing exception messages as the attribute appears truncated. The exception messages are clearer when it checks that the attribute length corresponds to the number of bytes read.
This pull request has now been integrated.
Changeset: 2b4a423f
Author: Alan Bateman <alanb at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/2b4a423f
Stats: 567 lines in 8 files changed: 562 ins; 1 del; 4 mod
8255542: Attribute length of Module, ModulePackages and other attributes is ignored
Reviewed-by: mchung, dfuchs, chegar
-------------
PR: https://git.openjdk.java.net/jdk/pull/1407
More information about the core-libs-dev
mailing list