RFR: 8256167: Convert JDK use of `Reference::get` to `Reference::refersTo`

Kevin Rushforth kcr at openjdk.java.net
Fri Dec 4 20:08:16 UTC 2020


On Thu, 3 Dec 2020 22:54:54 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> This patch replaces some uses of `Reference::get` to `Reference::refersTo` to avoid keeping a referent strongly reachable that could cause unnecessary delay in collecting such object.   I only made change in some but not all classes in core libraries when working with Kim on `Reference::refersTo`.    The remaining uses are left for the component owners to convert at appropriate time.

You have a typo that will cause a compilation error.

src/java.base/share/classes/java/util/WeakHashMap.java line 437:

> 435:         int index = indexFor(h, tab.length);
> 436:         Entry<K,V> e = tab[index];
> 437:         while (e != null && !(e.hash == h && matchesKey(e, k))

This doesn't compile, which is why the checks from the GitHub actions build failed.

-------------

Changes requested by kcr (Author).

PR: https://git.openjdk.java.net/jdk/pull/1609


More information about the core-libs-dev mailing list