Integrated: 8246778: Compiler implementation for Sealed Classes (Second Preview)
Jan Lahoda
jlahoda at openjdk.java.net
Mon Dec 7 11:14:14 UTC 2020
On Fri, 27 Nov 2020 16:57:54 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this iteration we are:
>>
>> * Enhancing narrowing reference conversion to allow for stricter checking of cast conversions with respect to sealed type hierarchies
>>
>> * Also local classes are not considered when determining implicitly declared permitted direct subclasses of a sealed class or sealed interface
>>
>> * renaming Class::permittedSubclasses to Class::getPermittedSubclasses, still in the same method, the return type has been changed to Class<?>[] instead of the previous ClassDesc[]
>>
>> * adding code to make sure that annotations can't be sealed
>>
>> * improving some tests
>>
>>
>> TIA
>>
>> Related specs:
>> [Sealed Classes JSL](http://cr.openjdk.java.net/~gbierman/jep397/jep397-20201104/specs/sealed-classes-jls.html)
>> [Sealed Classes JVMS](http://cr.openjdk.java.net/~gbierman/jep397/jep397-20201104/specs/sealed-classes-jvms.html)
>> [Additional: Contextual Keywords](http://cr.openjdk.java.net/~gbierman/jep397/jep397-20201104/specs/contextual-keywords-jls.html)
>
> This PR strives to reflect the review comments from 1227:
> * adjustments to javadoc of j.l.Class methods
> * package access checks in Class.getPermittedSubclasses()
> * fixed to the narrowing conversion/castability as pointed out by Maurizio
This pull request has now been integrated.
Changeset: 637b0c64
Author: Jan Lahoda <jlahoda at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/637b0c64
Stats: 1138 lines in 16 files changed: 1055 ins; 11 del; 72 mod
8246778: Compiler implementation for Sealed Classes (Second Preview)
Co-authored-by: Vicente Romero <vromero at openjdk.org>
Co-authored-by: Harold Seigel <hseigel at openjdk.org>
Reviewed-by: lfoltan, mchung, alanb, mcimadamore, chegar
-------------
PR: https://git.openjdk.java.net/jdk/pull/1483
More information about the core-libs-dev
mailing list