RFR: 8166026: Refactor java/lang shell tests to java [v3]

Roger Riggs rriggs at openjdk.java.net
Mon Dec 7 15:49:12 UTC 2020


On Sun, 6 Dec 2020 17:29:27 GMT, Ivan Šipka <isipka at openjdk.org> wrote:

>> Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test.
>
> Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8166026: Refactor java/lang shell tests to java

test/jdk/java/lang/Thread/UncaughtExceptionsTest.java line 68:

> 66:     @Test(dataProvider = "testCases")
> 67:     public void test(String className, int exitValue, String stdOutMatch, String stdErrMatch) throws Throwable {
> 68:         ProcessBuilder processBuilder = ProcessTools.createJavaProcessBuilder(String.format("Seppuku$%s",className));

The class renaming looks incomplete. Here and in the error texts above.
Seppuku does not look right as the host class for the test, they are nested classes of UncaughtExceptionsTest.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1578


More information about the core-libs-dev mailing list